This repository has been archived by the owner on Jan 22, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 370
Client: Allow users to breed moji #99
Merged
therobinkim
merged 12 commits into
hyperledger-archives:feat/client-breed
from
therobinkim:client-breed
Aug 16, 2018
Merged
Client: Allow users to breed moji #99
therobinkim
merged 12 commits into
hyperledger-archives:feat/client-breed
from
therobinkim:client-breed
Aug 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therobinkim
commented
Jun 28, 2018
code/part-two/client/source/Moji.jsx
Outdated
<h2>{mojiView}</h2> | ||
<table> | ||
<h2>{mojiView} {' '} {sireIndicator}</h2> | ||
<table class="table"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to fix class
to be className
.
therobinkim
commented
Jun 28, 2018
code/part-two/client/source/Moji.jsx
Outdated
@@ -78,7 +76,6 @@ export class Moji extends React.Component { | |||
}) | |||
.then(() => this.setState(prevState => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I can probably simplify the this.setState
so it doesn't use prevState
f3d0886
to
014a7e7
Compare
delventhalz
approved these changes
Jul 26, 2018
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Closes hyperledger-archives#98. Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Closes hyperledger-archives#43. Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
Signed-off-by: Robin Kim <[email protected]>
a785654
to
ec29a9f
Compare
This was referenced Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not yet ready for review.This PR is ready for review as of July 3.
Closes #68, closes #43, closes #98.