Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON and YAML chain and token configs #88

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

jmrossy
Copy link
Collaborator

@jmrossy jmrossy commented Dec 1, 2023

Fixes https://github.com/hyperlane-xyz/issues/issues/732

  • Add support for JSON and YAML chain and token configs
  • Update some stale docs
  • Cleanup default chain and token const files

@jmrossy jmrossy requested a review from yorhodes December 1, 2023 20:14
@jmrossy jmrossy requested a review from nambrot as a code owner December 1, 2023 20:14
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperlane-warp-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 3:52pm

@avious00
Copy link
Contributor

avious00 commented Dec 4, 2023

thanks for adding the additional comments at the top of the snippets in /chains.yaml + /chains.ts

Copy link
Collaborator

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 for fixing this

We are due for a more holistic overhaul of artifacts that are reused across, but one step at a time :)

src/consts/tokens.yaml Outdated Show resolved Hide resolved
src/features/chains/metadata.ts Show resolved Hide resolved
src/features/tokens/metadata.ts Show resolved Hide resolved
@jmrossy jmrossy merged commit ea94576 into main Dec 5, 2023
6 checks passed
@jmrossy jmrossy deleted the rossy/json-support branch December 5, 2023 15:56
jmrossy added a commit that referenced this pull request Dec 22, 2023
* Add support for JSON and YAML chain and token configs (#88)
- Update some stale docs
- Cleanup default chain and token const files

* Upgrade Wagmi and RainbowKit (#89)
- Upgrade repo to yarn 4
- Upgrade wagmi and rainbowkit versions
- Use Viem instead of Ethers for tx sending
- Refactor wallet/hooks.ts into smaller protocol-specific files
- Fix small cosmos metadata issue

* Validate cosmos recipient address bech32 prefix (#94)

* Cosmos factory token support (#91)
- Add support for cosmos factory tokens
- Combine automatic and manual token selector components

* Configure Viction and Eclipsefi

* Disable viction tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants