Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Add erc20 decimals and token metadata tooling #56

Merged
merged 18 commits into from
Apr 6, 2023
Merged

Add erc20 decimals and token metadata tooling #56

merged 18 commits into from
Apr 6, 2023

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Mar 23, 2023

Description:

  • Add decimals to synthetic ERC20
  • Update config and tests for default token metadata
  • Update example token config to fetch metadata

Fixes hyperlane-xyz/hyperlane-monorepo#1998
Uses hyperlane-xyz/hyperlane-monorepo#2065

Drive-by:

  • Update to 1.3.1

@yorhodes yorhodes requested a review from jmrossy as a code owner March 23, 2023 17:58
@yorhodes yorhodes requested a review from nambrot March 23, 2023 18:02
src/deploy.ts Outdated Show resolved Hide resolved
contracts/HypERC20.sol Outdated Show resolved Hide resolved
src/deploy.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, just a few small things

src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/deploy.ts Outdated Show resolved Hide resolved
src/deploy.ts Outdated Show resolved Hide resolved
src/deploy.ts Outdated Show resolved Hide resolved
@yorhodes yorhodes requested review from nambrot and jmrossy April 5, 2023 19:54
contracts/HypERC20.sol Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
contracts/test/ERC721Test.sol Show resolved Hide resolved
src/deploy.ts Show resolved Hide resolved
test/erc20.test.ts Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/deploy.ts Outdated Show resolved Hide resolved
src/deploy.ts Show resolved Hide resolved
src/deploy.ts Show resolved Hide resolved
src/deploy.ts Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Hardhat Coverage Report

Coverage after merging decimals into main will be
91.67% 0.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts
   HypERC20.sol84.62%100%80%87.50%47
   HypERC20Collateral.sol100%100%100%100%
   HypERC721.sol100%100%100%100%
   HypERC721Collateral.sol84.62%100%83.33%85.71%25
   HypNative.sol86.67%100%80%87.50%65
contracts/extensions
   HypERC721URICollateral.sol100%100%100%100%
   HypERC721URIStorage.sol85.71%100%83.33%87.50%70
contracts/libs
   Message.sol80%100%80%80%23
   TokenRouter.sol100%100%100%100%

@yorhodes yorhodes merged commit aff4e3a into main Apr 6, 2023
@yorhodes yorhodes deleted the decimals branch April 6, 2023 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warp Route synthetics should have the same decimals as the collateral token
4 participants