Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry): schema conformance #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sambacha
Copy link

@sambacha sambacha commented Feb 6, 2025

Fix the usage of exclusiveMinimum

Description

for the “chainId”, “blocks.estimateBlockTime”, “grpcUrls.concurrency”, “retry.maxRequests”, and “retry.baseRetryMs”), the keyword exclusiveMinimum is given a numeric value. In JSON Schema draft‑07 the exclusiveMinimum keyword is of type boolean, and is used with a separate minimum value as this enforces a strict inequality.

Backward compatibility

Technically, no as there was no strict inequality per se defined.

Testing

YMMV

Fix the usage of `exclusiveMinimum`:

Ffor the “chainId”, “blocks.estimateBlockTime”, “grpcUrls.concurrency”, “retry.maxRequests”, and “retry.baseRetryMs”), the keyword `exclusiveMinimum` is given a numeric value. In JSON Schema draft‑07 the `exclusiveMinimum` keyword is of type boolean, and is used with a separate `minimum` value as this enforces a strict inequality.
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: d766279

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant