feat(server): Remove into_service api

[tottoto]

Removes into_service() api. This is the same as the one composed of the layers and the Routes.

[djc]

So how would you spell this in 0.13?

[tottoto]

What is the purpose? Should this api be kept in 0.13?

[djc]

I'm asking what the replacement looks like, in order to better understand how much boilerplate this call is hiding.

[tottoto]

I see. In the case where this API is used, users can build Routes in advance, so they can set some layers to the Routes with some means, for example tower's ServiceBuilder.

[djc]

I understand -- do you have a code snippet showing what that would look like?

[tottoto]

The following is an example if using tower's ServiceBuilder:

let routes = Routes::new(service()).prepare();

let service = tower::ServiceBuilder::new()
    .layer(layer())
    .service(routes);

[tobz]

At a high level, I wonder if it makes more sense to think about deprecating either Routes or Server entirely.

It seems like they both do nearly the same thing, except for Server allowing for actually running (server) the server.. so it feels weird to incrementally deprecate a method here and there when it's (IMO) a bigger problem that they two types both exist with such heavy overlap.

[tottoto]

At a high level, I wonder if it makes more sense to think about deprecating either Routes or Server entirely.

I don't think so. Routes is responsible for configuring the service router, while Server builds a server on top of Routes, so their roles are different. It would make sense if Server could handle other Routes equivalents and allow us to change the service router to be used, but that would be a relatively big change.