Skip to content

docs(client): Include .pool_timer() in the Client builder example #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

sulami
Copy link
Contributor

@sulami sulami commented Apr 20, 2025

The example (/doctest) uses a pool idle timeout, which according to the docs doesn't actually do anything without a pool timer.

Including a timer makes this example less misleading.

The example (/doctest) uses a pool idle timeout, which according to the
docs doesn't actually do anything without a pool timer.

Including a timer makes this example less misleading.
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@seanmonstar seanmonstar merged commit 9ac0dfe into hyperium:master Apr 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants