Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(register): password confirmation #85

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

mark-omarov
Copy link
Contributor

@mark-omarov mark-omarov commented Nov 8, 2023

Origin: #81 (comment)

Add a password confirmation field to the registration form.

  • API will require confirmPassword field on the registration endpoint
  • The confirmPassword and password fields will be validated by zod on API validation
  • UI on the registration form will have a "Confirm Password" field
  • Validation errors will be displayed on the UI the same way other validation errors
  • API test covers mismatch between confirmPassword and password (simple check, can be improved)

Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: 0700415

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Minor
@hyperdx/app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mark-omarov mark-omarov marked this pull request as ready for review November 8, 2023 00:42
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! As I was trying it out, I also thought #90 might be a nice improvement

@kodiakhq kodiakhq bot merged commit b1a537d into hyperdxio:main Nov 9, 2023
3 checks passed
@mark-omarov mark-omarov deleted the feat/register-pass-confirm branch November 9, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants