New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make the classes b/c with 0.1.0 #17

Merged

hussein-awala merged 1 commit into main from chore/backward_compatibility

Feb 25, 2024

Owner

hussein-awala commented Feb 25, 2024

This PR:

makes the classes backward compatible with 0.1.0 by avoiding failing when the removed parameters are provided
updates the docstring for all the classes
switch the classes that use run_in_executor to normal function to use the new implicit run_in_executor mechanism


          chore: make the classes b/c with 0.1.0

73fd58a

hussein-awala force-pushed the chore/backward_compatibility branch from 1d3d99f to 73fd58a Compare

February 25, 2024 20:41

hussein-awala merged commit 28d87be into main

2 checks passed

hussein-awala deleted the chore/backward_compatibility branch

February 25, 2024 20:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet