Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fluent tutorial #71

Merged
merged 10 commits into from
Nov 24, 2024
Merged

Added a fluent tutorial #71

merged 10 commits into from
Nov 24, 2024

Conversation

Joannis
Copy link
Member

@Joannis Joannis commented Nov 21, 2024

No description provided.

@Joannis Joannis requested a review from adam-fowler November 21, 2024 14:56
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some initial comments.

@Step {
We'll add a single route `GET /galaxies`, which lists all registered galaxies.

Because the database is empty now, we'll add a single Galaxy on boot!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worthwhile to add a PUT route that adds a galaxy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to mention it in the tutorial steps and maybe instead of adding a galaxy automatically using this route to add the galaxy

@Joannis Joannis enabled auto-merge November 21, 2024 16:18
@Joannis Joannis disabled auto-merge November 21, 2024 16:18
@Joannis Joannis requested a review from adam-fowler November 21, 2024 16:18
Hummingbird.docc/Tutorials/FluentUniverse/Fluent.tutorial Outdated Show resolved Hide resolved
@Step {
We'll add a single route `GET /galaxies`, which lists all registered galaxies.

Because the database is empty now, we'll add a single Galaxy on boot!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to mention it in the tutorial steps and maybe instead of adding a galaxy automatically using this route to add the galaxy

Hummingbird.docc/Tutorials/FluentUniverse/Fluent.tutorial Outdated Show resolved Hide resolved
Hummingbird.docc/Tutorials/FluentUniverse/Fluent.tutorial Outdated Show resolved Hide resolved
@Joannis Joannis requested a review from adam-fowler November 21, 2024 17:53
@Joannis Joannis requested a review from adam-fowler November 23, 2024 20:16
@adam-fowler adam-fowler enabled auto-merge (squash) November 24, 2024 11:14
@adam-fowler adam-fowler merged commit f6a38ce into main Nov 24, 2024
1 check passed
@Joannis Joannis deleted the jo/fluent-tutorial branch November 24, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants