Enh: Proper Guest Notice

[ArchBlood]

I think currently it is very confusing to guests visiting a HumHub instance that uses the polls module and see the ability to use the checkboxes along side a vote button, this makes them think that they are allowed to vote but instead are opening the login modal without proper notice. I believe we should use something like this P/R to properly notify guests that it is for logging in not to vote on the poll.

Logged In

Guest

[luke-]

@mbumpalumpa What do you think?

For me the radios are also a design part which turn the wall entry design into a poll. That's why I wouldn't simply remove them...

[ArchBlood]

@mbumpalumpa What do you think?

For me the radios are also a design part which turn the wall entry design into a poll. That's why I wouldn't simply remove them...

An alternative would be to disable them so to keep with the original design if that is preferred?

[ArchBlood]

Now shows both checkbox and radio fields disabled for guests.

Guests

Logged In

[mbumpalumpa]

@ArchBlood yes, disable is the way to go here. Tho I personally don't like how this looks. They look like something went wrong while loading, rather than being disabled. I’d suggest we keep the border and apply the background @input-bg-disabled, or change the border color on disable to @gray-lighter. In either case, I’d also use pointer: not-allowed; (@luke- opinion?). You can see an example of the border color change in the Carbon Design System.

Suggestions

Ignore the button text, as I did these "changes" as a user, not as a guest, just so we get a sense of the suggested changes.

---

Also, could you please add the missing <br> after the alert in guest mode? When inspecting the wall entry as a user, the <div class="alert alert-default">...</div> is enclosed inside <br>. However, in guest mode, the <br> after the alert is missing, so the alert is sticking to the button.

[ArchBlood]

@ArchBlood yes, disable is the way to go here. Tho I personally don't like how this looks. They look like something went wrong while loading, rather than being disabled. I’d suggest we keep the border and apply the background @input-bg-disabled, or change the border color on disable to @gray-lighter. In either case, I’d also use pointer: not-allowed; (@luke- opinion?). You can see an example of the border color change in the Carbon Design System.

Suggestions

Ignore the button text, as I did these "changes" as a user, not as a guest, just so we get a sense of the suggested changes.

Also, could you please add the missing `
` after the alert in guest mode? When inspecting the wall entry as a user, the `

...

` is enclosed inside `
`. However, in guest mode, the `
` after the alert is missing, so the alert is sticking to the button.

In this case wouldn't it be better to just remove the button itself for guests? Overall it would still give guests the impression that voting is an option for them which is terrible UI/UX, even if it is just a redirect to login, this was the original idea behind this P/R in the first place. 🤔

Another option would be disabling the button if it is still wanted for the design esthetics, I'd like to make as little change to the default styling of the button as possible, other designs should be done via custom theme instead of inline;