Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Delete DeviceID after Logout #63

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix: Delete DeviceID after Logout #63

merged 3 commits into from
Jan 6, 2025

Conversation

marc-farre
Copy link
Contributor

Issue #32

@luke- luke- marked this pull request as draft January 6, 2025 15:06
@marc-farre marc-farre mentioned this pull request Jan 6, 2025
Open
luke-
luke- requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@luke- luke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good! One small point regarding code style.

Regarding the cleanup, I've created a new issue here: #64

Probably we should create another PR for that?

controllers/TokenController.php Outdated Show resolved Hide resolved
controllers/TokenController.php Show resolved Hide resolved
@luke- luke- marked this pull request as ready for review January 6, 2025 19:41
@luke- luke- merged commit 625815b into master Jan 6, 2025
2 checks passed
@luke-
Copy link
Contributor

luke- commented Jan 6, 2025

@marc-farre Thanks. Merged and released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke- luke- luke- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc-farre @luke-