Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arch regex #1162

Closed
wants to merge 1 commit into from
Closed

fix arch regex #1162

wants to merge 1 commit into from

Conversation

Kyle-Kyle
Copy link
Contributor

This PR fixes two bugs:

  1. it is possible that show architecture reports this The target architecture is set to "auto" (currently "aarch64"). The current regex will extract auto" (currently "aarch64, which is completely wrong. We use the lazy mode to avoid having " in the arch name.
  2. the return result of get_arch should be set to upper case to match what's in arches dict

Copy link

🤖 Coverage update for 4daabe6 🔴

Old New
Commit 283a7f6 4daabe6
Score 71.2118% 71.1732% (-0.0386)

@Kyle-Kyle
Copy link
Contributor Author

Kyle-Kyle commented Dec 26, 2024

it seems that my gef is too old. the bug doesn't exist in the latest gef

@Kyle-Kyle Kyle-Kyle closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant