- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 improvements #1139
Merged
Merged
Python 3.10 improvements #1139
+433
−431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
Repository owner
deleted a comment from
Grazfather
Nov 1, 2024
I removed all comments because the PR is still draft and having those messes up how VSCode displays them directly into my code. Don't review until ready |
hugsy
requested review from
Grazfather,
daniellimws,
therealdreg,
ValekoZ and
theguy147
November 2, 2024 21:13
4 tasks
ValekoZ
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR for #1133 but purely esthetic, no functional changes
Cleans up the code to make it more in comformance with Python 3.10 capabilities.
Replaces:
Union
with|
Dict
/Set
/List
/Tuple
withdict
/set
/list
/tuple
Optional
with| None
if:
...elif
... ->match
Fixes:
gdb.events.*Event
->gdb.*Event
GefHeapManager.malloc_align_address
had itsceil
lambda moved as a proper (nested) functionLint:
except:
->except Exception:
if not .. in ..
->if .. not in ..