Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mm dispatch #95

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Cleanup mm dispatch #95

merged 3 commits into from
Feb 22, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Feb 22, 2024

This removes some overhead in the mm dispatch, which had increased the latency on all models.

The performances are now back to those advertized in the generation benchmark README.

The declarative checks are hard to read, and will be removed later.
The call to qfallback is also removed as it seems to be slow.
@dacorvo dacorvo merged commit a9ee9c5 into main Feb 22, 2024
3 checks passed
@dacorvo dacorvo deleted the cleanup_mm branch February 22, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant