Refactor QBitsTensor subclasses #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacorvo
force-pushed
the
refactor_weights_qbits
branch
from
88faee0
to
5609f3e
Compare
Allowing an optimizer to be passed to the quantize_weight function led to a cross-dependency with the optimizers, that might in turn need to quantize weights.
This aligns the organization of the QBitsTensor classes on the one used for QBytesTensor.
Also avoid exporting AWQ and TinyGemm classes at the top level.
dacorvo
force-pushed
the
refactor_weights_qbits
branch
2 times, most recently
from
ac9e95c
to
c23f155
Compare
dacorvo
force-pushed
the
refactor_weights_qbits
branch
from
c23f155
to
fe72fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a purely internal refactoring to ease the introduction of Marlin int4 kernels.