Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for training #654

Merged
merged 13 commits into from
Jul 23, 2024
Merged

Various fixes for training #654

merged 13 commits into from
Jul 23, 2024

Conversation

michaelbenayoun
Copy link
Member

@michaelbenayoun michaelbenayoun commented Jul 16, 2024

What does this PR do?

  • Fixes the MPMD that happens when logging_steps < num_step_in_epoch at the end of the epoch.
  • Fixes has_write_access_to_repo

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@michaelbenayoun michaelbenayoun changed the title Fix MPMP error at the end of epoch Various fixes Jul 17, 2024
@michaelbenayoun michaelbenayoun changed the title Various fixes Various fixes for training Jul 17, 2024
@michaelbenayoun michaelbenayoun marked this pull request as ready for review July 17, 2024 16:31
Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the MPMD issue, the changes look good to me in general.

optimum/neuron/utils/cache_utils.py Outdated Show resolved Hide resolved
@michaelbenayoun michaelbenayoun merged commit 5148118 into main Jul 23, 2024
9 of 11 checks passed
@michaelbenayoun michaelbenayoun deleted the fix_mpmd_at_end_of_epoch branch July 23, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants