Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NNCF 2.14 and OV 2024.5 #997

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Support NNCF 2.14 and OV 2024.5 #997

merged 7 commits into from
Nov 21, 2024

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Nov 12, 2024 •
edited
Loading

What does this PR do?

OpenVINO 2024.5 and NNCF 2.14 are out. In this PR, the required OV version is updated. Also, some test references are changed accordingly.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@nikita-savelyevv nikita-savelyevv added the openvino-test Trigger OpenVINO slow tests label Nov 12, 2024
eaidova
eaidova reviewed Nov 15, 2024
View reviewed changes
setup.py Show resolved Hide resolved
@nikita-savelyevv nikita-savelyevv marked this pull request as ready for review November 20, 2024 13:20
@nikita-savelyevv
Copy link
Collaborator Author

nikita-savelyevv commented Nov 20, 2024 •
edited
Loading

OpenVINO slow tests on stable NNCF and OV versions failing with huggingface_hub.errors.RepositoryNotFoundError: 401 Client Error should not block us.

@AlexKoff88 AlexKoff88 merged commit 595246d into huggingface:main Nov 21, 2024
17 of 39 checks passed
@echarlaix echarlaix mentioned this pull request Nov 21, 2024
Merged
@echarlaix
Copy link
Collaborator

The doc generation is failing with

ERROR: No matching distribution found for openvino==2024.5.0; extra == "openvino"

https://github.com/huggingface/optimum-intel/actions/runs/11948762040/job/33306899617

resulting in optimum doc generation failing since then https://github.com/huggingface/optimum/actions/workflows/build_main_documentation.yml

should be fixed with #1006 cc @AlexKoff88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaidova eaidova eaidova approved these changes

@AlexKoff88 AlexKoff88 AlexKoff88 approved these changes

Assignees
No one assigned
Labels
openvino-test Trigger OpenVINO slow tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikita-savelyevv @HuggingFaceDocBuilderDev @echarlaix @AlexKoff88 @eaidova