Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix facebook/hf-seamless-m4t-medium crash #1433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sywangyi
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jiminha
Copy link
Collaborator

jiminha commented Oct 17, 2024

@sywangyi Could you explain why other two models work but not facebook/hf-seamless-m4t-medium ?

@sywangyi
Copy link
Collaborator Author

facebook/hf-seamless-m4t-medium hit the condition that decode input id length is 2. and decoder_start_token_id is not in the decode input id, which cause issue in https://github.com/huggingface/optimum-habana/blob/main/optimum/habana/transformers/generation/utils.py#L249

@jiminha
Copy link
Collaborator

jiminha commented Oct 22, 2024

facebook/hf-seamless-m4t-medium hit the condition that decode input id length is 2. and decoder_start_token_id is not in the decode input id, which cause issue in https://github.com/huggingface/optimum-habana/blob/main/optimum/habana/transformers/generation/utils.py#L249

Is this only model that you are aware of which has decode input id length of 2?
When does below statement return true? Is this model specific, and only happening on this ht-seamless-m4t model?
elif (decoder_input_ids[:, 0] != decoder_start_token_id[:, 0]).all().item():

What other tests do you recommend us to run to make sure this new code in utils.py doesn't break any other models run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants