Minor improvments to busy_wait #447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-soare
commented
Sep 20, 2024
| # TODO(rcadene): find an alternative: from python 11, time.sleep is precise | ||
| end_time = time.perf_counter() + seconds | ||
| while time.perf_counter() < end_time: | ||
| def precise_sleep(seconds: float, blocking: bool = False): |
There was a problem hiding this comment.
I'm wondering if this should default to blocking = True, and have the fancy non-cpu-blocking version for advanced users.
alexander-soare
commented
Sep 20, 2024
| """ | ||
| end_time = time.perf_counter() + seconds | ||
| # 20 ms buffer is usually enough to account for an overly-long last sleep, even with heavy system load. | ||
| end_time_with_buffer = end_time - 0.02 |
There was a problem hiding this comment.
I tried increasing this buffer till I saw clear advantage in using precise_sleep instead of time.sleep with maximal system load. Please check on your end.
alexander-soare
added
✨ Enhancement
alexander-soare
changed the title
alexander-soare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Makes
busy_waitmore precise for Linux and non-blocking on other platforms.Renames
busy_waittoprecise_sleep, as it's not actually a "busy" wait.Adds a benchmarking script to the
if __name__ = "__main__"(I know this is unconventional, but it feels convenient and useful enough to break the rules for).How it was tested
Ran the benchmarking snippet with all cores busy and found that
precise_sleepwas better.How to checkout & try? (for the reviewer)
See the benchmarking snippet in the code.