Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this issue is not as straightforward to fix as that. Given an Inference Endpoint url, we can't be sure that the model is powered by Text-Embedding-Inference and therefore that we should use the
/similarity
route. For example, if you go to https://huggingface.co/sentence-transformers/all-mpnet-base-v2 > "Inference Endpoints (dedicated)", the default framework won't be TEI but transformers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could check the Inference Endpoint info to get this information (e.g. send a call to
model + "/info"
) but it feels clunky. Ping @osanseviero if you have a better idea on this.