Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diffusionkit to local-apps #875

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ardaatahan
Copy link
Contributor

@ardaatahan ardaatahan commented Aug 29, 2024

Opening this PR as per @Vaibhavs10's suggestion here regarding DiffusionKit LocalApps integration.

This PR:

  1. Adds diffusionkit to the LOCAL_APPS object in local-apps.ts.
  2. Adds snippetDiffusionKit function that generates the snippet string for diffusionkit in the same file.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for opening this PR and sorry for the delay. Conceptually approving the PR as the snippet looks good to me.

Will let @enzostvs chime in about what else is needed w.r.t to showing the snippet for the Local App itself.

Note: Please make sure to run the linter to make the linter tests pass.

@enzostvs
Copy link
Member

enzostvs commented Sep 3, 2024

Hi @ardaatahan,
Thanks for adding DiffusionKit as a new Local App!

I'll need your logo in .SVG format please 🙏

{
title: "Install from pip",
setup: "pip install diffusionkit",
content: command("diffusionkit-cli"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if binary is always the same mayber simpler to hardcode it a const command = string

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's maybe wait till the binary is packaged w/o pip for us to ship this one (as it's a bit redundant with the model-library, imo)

@julien-c
Copy link
Member

julien-c commented Sep 3, 2024

(also cc @Wauplin given #869 (review))

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to summarise discussions on next steps w/ @ZachNagengast @atiorh

Argmax will put DiffusionKit over on brew and we'll update snippets accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants