-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refac docstrings in training_utils.py #9724
base: main
Are you sure you want to change the base?
Refac docstrings in training_utils.py #9724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Can you run make style
to automatically apply the correct style corrections to fix the failing CI test?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @stevhliu, did like you asked. Will make sure to run the command beforehand in the future. |
Hmm, can you also please try running |
Hi @stevhliu I tried running Just for reference here is one of the errors I got from after running the make command.
|
Could you upgrade/downgrade your ruff version to |
Hi @a-r-r-o-w , after downgrading ruff to the version you specified, I get the following error messages:
Trying to fix that, do you have any insights about this issue? Also apologies in advance if this is not the place to discuss issues like this. |
Hi @a-r-r-o-w @stevhliu I ran the two make commands. Output from
Output (partial, actual output is too big) from
What should my next steps be, do I have to run the Also just want to mention I really appreciate all the help I'm getting, thank you. |
What does this PR do?
Fixes #9567
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@a-r-r-o-w @stevhliu