New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added asserts and fixes for empty emb input in AdaLayerNorm #9693

Open

Godofnothing wants to merge 2 commits into huggingface:main from Godofnothing:ada_layer_norm_fix

Godofnothing commented Oct 16, 2024

This PR raises asserts when conditioning is not provided to AdaLayerNorm.

Specifically:

One has to provide either timestep or temb argument to AdaLayerNorm.
Modulation embedding has to be provided either via CombinedTimestepLabelEmbeddings or emb argument in AdaLayerNormZero.
AdaLayerNormZeroSingle handles the case when number of channels in emb is not equal to x.
emb argument in AdaLayerNormZeroSingle becomes mandatory (currently, code would crash if emb is None).

Godofnothing added 2 commits

October 16, 2024 12:48


Added asserts and fixes for empty emb input in AdaLayerNorm

8a573fb


Fixed small typo

7be0a2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment