json: add optional return_file_name parameter#7948
Open
Sachin-0001 wants to merge 1 commit intohuggingface:mainfrom
Open
json: add optional return_file_name parameter#7948Sachin-0001 wants to merge 1 commit intohuggingface:mainfrom
Sachin-0001 wants to merge 1 commit intohuggingface:mainfrom
Conversation
dhruvildarji
added a commit
to dhruvildarji/datasets
that referenced
this pull request
Feb 23, 2026
Add an optional `return_file_name` parameter to `CsvConfig` that, when set to `True`, appends a `file_name` column containing the source file basename to every batch yielded by `_generate_tables`. Default is `False` to preserve backward compatibility. Part of huggingface#5806. Extends the file_name feature (already implemented for the JSON builder in huggingface#7948) to the CSV packaged builder. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
return_file_nameparameter to the JSON dataset loader.When enabled, a new
file_namecolumn is added containing the source file namefor each row. Default behavior is unchanged.
Changes:
return_file_nameto JsonConfigMotivation:
This helps resume training from checkpoints by identifying already-consumed data shards.
Fixes #5806