-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added enter to insert new line on mobile instead of default. #1475
Conversation
Hey, thanks a lot for opening a PR for this. Will review it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment but otherwise should be good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified a few things, mostly i'm now detecting virtual keyboards instead of relying on viewport width. This should help detecting touchscreens with wider screens as well, other than that lgtm! 🚀
…face#1475) * Added enter to insert new line on mobile instead of default. * fix: lint * Removed unnecessary if statement * feat: use virtual keyboard detection instead of viewport width --------- Co-authored-by: Nathan Sarrazin <[email protected]>
Fix #1471 for mobile users to add a new line to their messages.