Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): Basic tool support for OpenAI models #1447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(tools): Basic tool support for OpenAI models #1447

wants to merge 2 commits into from

Conversation

gladish
Copy link

@gladish gladish commented Sep 3, 2024

No description provided.

@harisyammnv
Copy link
Contributor

really helpful

@nsarrazin nsarrazin added enhancement New feature or request models This issue is related to model performance/reliability tools labels Sep 9, 2024
@nsarrazin nsarrazin self-assigned this Sep 9, 2024
@nsarrazin nsarrazin self-requested a review September 9, 2024 12:51
nsarrazin
nsarrazin reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type checks seems to fail in src/lib/server/textGeneration/tools.ts with

Property 'correlationKey' is missing in type '{ name: string; parameters: Record<string, string>; }' but required in type 'ToolCall'.ts(2741)

could you take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarrazin nsarrazin nsarrazin left review comments

Assignees

@nsarrazin nsarrazin

Labels
enhancement New feature or request models This issue is related to model performance/reliability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gladish @harisyammnv @nsarrazin