Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ReduceMin and ReduceMax Ops. Found these in use in a Detectron2 exported model.
Implementation
Supports Ops version 18+Backward compatible as far as I can tellOpen Questions
13 -> 18
has moved theaxes
fromattributes
toinput
. Though it's trivial to handle this withget_attr_opt::<&[i64]>(node, "axes")
fallback, not sure if that's the right way of going about this!empty set
as input and prescribes-INF/ +INF
orDatatype::Min/ Datatype::Max
for the ops. Reference. I'm not sure if the return is supposed to be ascalar
?@LaurentMazare, any thoughts around these open questions?