Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Granite 7b Instruct model example #2487

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

atilag
Copy link
Contributor

@atilag atilag commented Sep 20, 2024

Hey team!
Than you very much for sharing your work :)

Granite LLM models have a very interesting Open Source license (Apache 2.0) and perform very well in many benchmarks.
There might be many potential Candle users who might be interested in this integration.

So far, I just copied the Llama example and adapted it, so for the 7B Instruct was really straightforward.
If the community is interested, I'll be adding support for the rest of the models :)

Cheers!

Copy link
Collaborator

@LaurentMazare LaurentMazare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@LaurentMazare
Copy link
Collaborator

Actually would you mind adding a small readme in the example directory similar to the other readme, i.e. a link to the actual model card + some sample evaluation of the model. A random example here.

* Changing the default prompt to accomodate better the Language
  modality of the Granite 7b Instruct model
@LaurentMazare LaurentMazare merged commit 5fc4f17 into huggingface:main Sep 21, 2024
@LaurentMazare
Copy link
Collaborator

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants