Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for metal tanh. #2475

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix for metal tanh. #2475

merged 1 commit into from
Sep 13, 2024

Conversation

LaurentMazare
Copy link
Collaborator

Use precise::tanh instead of tanh to avoid easily generating NaN values rather than 1 or -1.

@LaurentMazare LaurentMazare merged commit c09afc2 into main Sep 13, 2024
11 checks passed
@LaurentMazare LaurentMazare deleted the metal-tanh-fix branch September 13, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LaurentMazare