Add DINOv2Reg4 + PlantCLEF2024 #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
Could you remove the commented code? We try to have as little as possible otherwise it quickly gets out of sync with the rest.
There was a problem hiding this comment.
Thanks Laurent for your comments. I updated the files following your suggestions. Please tell me if the code requires additional modifications. Regards,
There was a problem hiding this comment.
Looks great thanks, would you mind running rustfmt as well as clippy, both seem to broke in the CI at the moment.
…n + remove extra comments + Update README ( source image changed and so the predictions )
|
I just ran clippy an rustfmt. I think the code is fine now. Please don't hesitate to tell me otherwise. |
LaurentMazare
approved these changes
Jun 29, 2024
|
Thanks! |
|
Thank you for adding my code. Regards, |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Jun 29, 2024
* Add: DINOv2Reg4 with PlantCLEF2024 weights and example ( See https://arxiv.org/abs/2309.16588 and https://zenodo.org/records/10848263 ) * Remove extra files + update README to download them + remove extra lines * minor fix (README remove extra spaces) * minor fix (README: Fix image url) * Modif: Add back interpolate_pos_encoding() + fix when no interpolation + remove extra comments + Update README ( source image changed and so the predictions ) * Fix: Improve code lisibility with '$ cargo clippy' and '$ cargo fmt' * Another clippy fix. --------- Co-authored-by: x-VEspit <[email protected]> Co-authored-by: laurent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the DINOv2Reg4 model as well as an example to use it.
The weights come from the contest PlantCLEF2024.
This pull request follows the emitted issue from monday evening : #2287
See:
(model specs from meta) https://arxiv.org/abs/2309.16588
(model weights PC24) https://zenodo.org/records/10848263
(PlantCLEF2024 contest) https://huggingface.co/spaces/BVRA/PlantCLEF2024
Thanks for your time,
Regards,
Vincent.