Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the mmv kernels for small batch sizes. #2075

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Add the mmv kernels for small batch sizes. #2075

merged 8 commits into from
Apr 16, 2024

Conversation

LaurentMazare
Copy link
Collaborator

@LaurentMazare LaurentMazare commented Apr 16, 2024 •
edited
Loading

Only handling the batch sizes up to 4 to avoid including too many kernels.
See #2074 and ggerganov/llama.cpp#5351 (comment) for more context.

@LaurentMazare LaurentMazare mentioned this pull request Apr 16, 2024
Closed
@EricLBuehler EricLBuehler mentioned this pull request Apr 16, 2024
Closed
@LaurentMazare LaurentMazare merged commit 2817643 into main Apr 16, 2024
10 checks passed
@LaurentMazare LaurentMazare deleted the more-mmv-kernels branch April 16, 2024 19:30
@EricLBuehler
Copy link
Member

@LaurentMazare, thank you for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LaurentMazare @EricLBuehler