PyO3: Add CI #1135
Merged
PyO3: Add CI #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentMazare
approved these changes
Oct 20, 2023
|
Thanks, that's a great thing to have! |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Oct 25, 2023
* Add PyO3 ci * Update python.yml * Format `bert.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You shouldn't have to trust me, that the tests i add actually pass. This PR adds a simple CI run to perform the following steps:
maturin develop -rstubfiles match the current implemenetation via:python stub.py --checkblack --check .python -m pytest -s -v testsThis CI is only triggered if there were changes in the
candle-pyo3subdirectory, to not block the normal development of candle.