Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Universal Assisted Generation #2412

Open
wants to merge 84 commits into
base: main
Choose a base branch
from

Conversation

danielkorat
Copy link
Contributor

@danielkorat danielkorat commented Oct 14, 2024

Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles
require additional reviews. Alternatively, you can write a community article following the process here.

Preparing the Article

You're not quite done yet, though. Please make sure to follow this process (as documented here):

  • Add an entry to _blog.yml.
  • Add a thumbnail. There are no requirements here, but there is a template if it's helpful.
  • Check you use a short title and blog path.
  • Upload any additional assets (such as images) to the Documentation Images repo. This is to reduce bloat in the GitHub base repo when cloning and pulling. Try to have small images to avoid a slow or expensive user experience.
  • Add metadata (such as authors) to your md file. You can also specify guest or org for the authors.
  • Ensure the publication date is correct.
  • Preview the content. A quick way is to paste the markdown content in https://huggingface.co/new-blog. Do not click publish, this is just a way to do an early check.

Here is an example of a complete PR: #2382

Getting a Review

Please make sure to get a review from someone on your team or a co-author.
Once this is done and once all the steps above are completed, you should be able to merge.
There is no need for additional reviews if you and your co-authors are happy and meet all of the above.

Feel free to add @osanseviero or @pcuenca as reviewers if you want a final check. They'll be biased toward light reviews
(e.g., check for proper metadata) rather than content reviews unless explicitly asked.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit in the future directions. Other than that, LGTM :D

universal_assisted_generation.md Outdated Show resolved Hide resolved
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🔥

_blog.yml Outdated
author: danielkorat
guest: true
thumbnail: /blog/assets/optimum_intel/intel_thumbnail.png
date: October 15, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update the date

universal_assisted_generation.md Outdated Show resolved Hide resolved
universal_assisted_generation.md Outdated Show resolved Hide resolved
universal_assisted_generation.md Outdated Show resolved Hide resolved
universal_assisted_generation.md Outdated Show resolved Hide resolved
@pcuenca
Copy link
Member

pcuenca commented Oct 18, 2024

I took the liberty to resolve the conflict with main

@danielkorat
Copy link
Contributor Author

Nit in the future directions. Other than that, LGTM :D

Thanks, that section was WIP

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll let you and @gante merge when you are ready.

universal_assisted_generation.md Outdated Show resolved Hide resolved
universal_assisted_generation.md Outdated Show resolved Hide resolved
@danielkorat
Copy link
Contributor Author

danielkorat commented Oct 21, 2024

@gante
Please hold on merging, I might add benchmarks for Llama-3.1-70b and mistralai/Mixtral-8x22B-Instruct-v0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants