allocate 80% for cpu is unset in max_memory
#2219
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR modifies
max_memory
by allocating 80% of cpu memory of "cpu" is not passed inmax_memory
. The idea was in case the user did not specify the cpu allocation usingmax_memory
arg, we should just infer from the current system available memory minus some reserved pool for the OS to continue to work. Otherwise, we will move directly to disk offload.cc @mfuntowicz as you suggested.
Before this PR:
After this PR
TODO: