Capability to display sideloaded apks#3
Open
kevin-schmid wants to merge 3 commits intohugegreenbug:mainfrom
Open
Capability to display sideloaded apks#3kevin-schmid wants to merge 3 commits intohugegreenbug:mainfrom
kevin-schmid wants to merge 3 commits intohugegreenbug:mainfrom
Conversation
Owner
|
I tried this patch out. I had the following issues apart from the one you mentioned above:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the App model to use the more generic PackageItemInfo. Everything else is done in the AppManager.
I used this stackoverflow post to add the getAppsThroughPackages method which returns a list that is combined with your queryIntentActivities lookup. I also had to change the startApp method to be able to launch intents without leanback.
One open issue: I can't load a banner, so I use the icon which looks kinda ugly. I changed the behaviour that if no banner is found the icon is always used.