Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Marshmallow 3 #926

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Support Marshmallow 3 #926

wants to merge 4 commits into from

Conversation

stefanor
Copy link

I'm unsure about 3d3591f, but the rest seems pretty straightforward:

  1. Take kwargs in post-processors, as marshmallow expects. They've added new named arguments, over time.
  2. Handle ValueError in validation.
  3. Set a default value for context in MarshmallowInputSchema. This is the bit I'm unsure of.
  4. Bump marshmallow deps in tox.

Fixes: #859

@stefanor
Take kwargs in marshmallow post-processors
c37a2e6 
This is expected by upstream, and they have added arguments in newer
releases.

Fixes: hugapi#859
@stefanor
Handle ValueError in mashmallow validation
091488d 
Part of: hugapi#859
@stefanor
Set a default value for MarshmallowInputSchema's context
ad6a14d 
This is a lazy fix to a test, without fully understanding the codebase.
It looks like context *should* be provided when needed, I'm not quite
sure why it isn't being.
@stefanor
tox: Bump mashmallow 3 deps
ac46dd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests fail
1 participant
@stefanor