Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cae): add new resource to manage timer rule #6198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:
Add new resource (huaweicloud_cae_timer_rule) to manage a timer rule for starting and stopping components.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource.
2. add corresponding document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cae -f TestAccTimerRule_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccTimerRule_basic -timeout 360m -parallel 10
=== RUN   TestAccTimerRule_basic
=== PAUSE TestAccTimerRule_basic
=== CONT  TestAccTimerRule_basic
--- PASS: TestAccTimerRule_basic (117.39s)
PASS
coverage: 36.2% of statements in ./huaweicloud/services/cae
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae       117.458s        coverage: 36.2% of statements in ./huaweicloud/services/cae
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

      ab. Related resources (parent resources) not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      image

      bb. Related resources (parent resources) not found
      image

@wuzhuanhong wuzhuanhong force-pushed the cae_timer_rule branch 2 times, most recently from fe803ea to e65b74c Compare January 15, 2025 08:13
@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o cae -f TestAccTimerRule_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccTimerRule_basic -timeout 360m -parallel 10
=== RUN TestAccTimerRule_basic
=== PAUSE TestAccTimerRule_basic
=== CONT TestAccTimerRule_basic
--- PASS: TestAccTimerRule_basic (131.63s)
PASS
coverage: 25.7% of statements in ./huaweicloud/services/cae
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae 131.702s coverage: 25.7% of statements in ./huaweicloud/services/cae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant