Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cae): add new resource to manage domain name #6179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:
Add new resource (huaweicloud_cae_domain) to bind domain for CAE environment.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource.
2. add corresponding document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cae -f TestAccResourceDomain_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccResourceDomain_basic -timeout 360m -parallel 10
=== RUN   TestAccResourceDomain_basic
=== PAUSE TestAccResourceDomain_basic
=== CONT  TestAccResourceDomain_basic
--- PASS: TestAccResourceDomain_basic (20.07s)
PASS
coverage: 12.6% of statements in ./huaweicloud/services/cae
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae       20.143s coverage: 12.6% of statements in ./huaweicloud/services/cae
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

      ab. Related resources (parent resources) not found
      The environment not found.
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

      bb. Related resources (parent resources) not found
      The environment not found.
      image

@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o cae -f TestAccResourceDomain_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccResourceDomain_basic -timeout 360m -parallel 10
=== RUN TestAccResourceDomain_basic
=== PAUSE TestAccResourceDomain_basic
=== CONT TestAccResourceDomain_basic
--- PASS: TestAccResourceDomain_basic (30.52s)
PASS
coverage: 9.0% of statements in ./huaweicloud/services/cae
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae 30.578s coverage: 9.0% of statements in ./huaweicloud/services/cae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants