Abstract and fix middlewares #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
force-pushed
the
attribute-provider/PR
branch
from
e96d282 to
cd9b3e4
Compare
iRevive
reviewed
Dec 4, 2024
trace/client/src/main/scala/org/http4s/otel4s/middleware/trace/client/AttributeProvider.scala
Show resolved
Hide resolved
NthPortal
commented
Dec 4, 2024
.../server/src/main/scala/org/http4s/otel4s/middleware/trace/server/TypedServerAttributes.scala
Outdated
Show resolved
Hide resolved
NthPortal
force-pushed
the
attribute-provider/PR
branch
from
cd9b3e4 to
f515c75
Compare
|
@ioleo can you have a look and let me know if this meets your needs? |
iRevive
reviewed
Dec 6, 2024
...lient/src/main/scala/org/http4s/otel4s/middleware/trace/client/ClientMiddlewareBuilder.scala
Outdated
Show resolved
Hide resolved
Add abstraction to middlewares to support full customisation of span names and attributes while keeping default use case as simple as possible. Fix default attributes to align with otel semantic conventions. Add tests for all attribute creation.
Use `MeterProvider` for `MetricsOps` rather than `Meter` and use `TracerProvider for middlewares rather than `Tracer`.
NthPortal
force-pushed
the
attribute-provider/PR
branch
from
4db2487 to
3b029ea
Compare
NthPortal
force-pushed
the
attribute-provider/PR
branch
from
d675146 to
6a3994b
Compare
NthPortal
commented
Dec 19, 2024
Comment on lines
96
to
108
| val middlewareVersion: AttributeProvider = | ||
| new AttributeProvider { | ||
| def requestAttributes[F[_]]( | ||
| request: Request[F], | ||
| urlTemplateClassifier: UriTemplateClassifier, | ||
| urlRedactor: UriRedactor, | ||
| headersAllowedAsAttributes: Set[AuthScheme], | ||
| ): Attributes = Attributes(TypedAttributes.middlewareVersion) | ||
| def responseAttributes[F[_]]( | ||
| response: Response[F], | ||
| headersAllowedAsAttributes: Set[AuthScheme], | ||
| ): Attributes = Attributes.empty | ||
| } |
There was a problem hiding this comment.
I'm not sure if this is a reasonable thing to do or not, but it's a separate commit so it will be easy to remove if we decide not
NthPortal
commented
Dec 31, 2024
| spanDataProvider: SpanDataProvider, | ||
| urlTemplateClassifier: UriTemplateClassifier, | ||
| headersAllowedAsAttributes: HeadersAllowedAsAttributes, | ||
| shouldTrace: RequestPrelude => ShouldTrace, |
There was a problem hiding this comment.
upon further thought, it's weird to me that this is a Function1 and not a SAM trait. I don't know if changing that has to happen in this PR (though given all the other changes, it would seem weird for it to happen elsewhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add abstraction to middlewares to support full customisation of span names and attributes while keeping default use case as simple as possible.
Fix default attributes to align with otel semantic conventions.
Add tests for all attribute creation.