multi-socket support #124
multi-socket support #124
Conversation
hnaderi
force-pushed
the
multi-socket-support
branch
3 times, most recently
from
c73a986 to
5519733
Compare
This implementation uses curl multi socket drive, and uses FileDescriptorPoller from cats effect. It allows using this library alongside other cats effect libraries.
hnaderi
force-pushed
the
multi-socket-support
branch
from
5519733 to
829ba96
Compare
curl/src/main/scala/org/http4s/curl/unsafe/CurlMultiPerformPoller.scala
Outdated
Show resolved
Hide resolved
|
|
||
| override def needsPoll(poller: Poller): Boolean = needsPoll | ||
|
|
||
| override def interrupt(targetThread: Thread, targetPoller: Poller): Unit = () |
There was a problem hiding this comment.
This is fine for now because everything is single-threaded, but to support multi-threading in the future we will have to figure out a way to interrupt curl_multi_poll somehow 🤔
There was a problem hiding this comment.
Yes, that was my concern as well. I hope we can use the proper event-driven approach for Windows by then, so we deprecate this polling stuff completely 😄
There was a problem hiding this comment.
but to support multi-threading in the future we will have to figure out a way to interrupt
curl_multi_pollsomehow
Aha :)
|
Apparently there is some race condition in this implementation, as multi socket runtime tests don't terminate sometimes. Sometimes even the test timeout does not work, that might give a clue for next investigations. |
closes #117