initial work on listener configuration #823
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
commented
Apr 22, 2021
|
|
||
| use async_std::net::{self, SocketAddr, TcpStream}; | ||
| use async_std::prelude::*; | ||
| use async_std::{io, task}; | ||
| use http_types::Url; | ||
|
|
||
| /// This represents a tide [Listener](crate::listener::Listener) that |
There was a problem hiding this comment.
this block of documentation is many commits out of date and needs to be updated before merge
This was referenced May 14, 2021
Closed
|
@jbr This seems fine to me - I'd approve it if it weren't a draft |
|
@jbr skimmed it quickly just now, and overall this looks good! -- would be happy to merge it, and iterate from there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft of listener configs