Add SARIF support #1221
Add SARIF support #1221
Conversation
github-actions
bot
added
cli
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 2 2
Lines 1627 1627
Branches 309 309
=======================================
Hits 1612 1612
Misses 15 15 Continue to review full report at Codecov.
|
| child.stdout.on('data', function (stdout) { | ||
| expect(stdout).not.toBe('') | ||
|
|
||
| if (os.platform() !== 'darwin') { |
There was a problem hiding this comment.
I have problem with this test running in macOS,
at first I was using the exact same way ChildProcess.exec, copied from json.spec.js. It seems macOS will truncate because sarif is too long.
So I tried to change to ChildProcess.spawn, seems like still have same issue. Not familiar with NodeJS, Let me know.
This looks like related:
nodejs/node#19218
There was a problem hiding this comment.
Sorry, maybe I didn't land it, but could this use the Jest snapshoting to work around it?
There was a problem hiding this comment.
Thanks for looking,
the issue was we are comparing the output against a pre-saved file,
in macOS only, the stdout seems have limit, and will lose part of the json,
the error was:
SyntaxError: Unexpected end of JSON input at at JSON.parse (<anonymous>)
> 34 | const jsonStdout = JSON.parse(stdout)
the tests for Linux and Windows does not have this issue and pass.
There was a problem hiding this comment.
In the above thread in nodejs repo, I can see we had a same issue before. #442
Our fix was trim down the size of the test. I can try to do the same to fix this as well so the test can be ran in macOS.
| "integrity": "sha512-Pzr3rol8fvhG/oJjIq2NTVB0vmdNNlz22FENhhPojYRZ4/ee08CfK4YuKmuL54V9MLhI1kpzxfOJ/63LzmZzDg==", | ||
| "dev": true, | ||
| "dependencies": { | ||
| "@types/sarif": "^2.1.4", |
There was a problem hiding this comment.
Aside: the types probably don't need to be a dependency, but that's an upstream issue
| child.stdout.on('data', function (stdout) { | ||
| expect(stdout).not.toBe('') | ||
|
|
||
| if (os.platform() !== 'darwin') { |
There was a problem hiding this comment.
Sorry, maybe I didn't land it, but could this use the Jest snapshoting to work around it?
coliff
added
the
keep-unstale
Add SARIF support, for #1045
usage:
-f sarif@coliff