Do not run schedule actions if there are no items#318
Open
Emerson wants to merge 1 commit intohtml-next:mainfrom
Open
Do not run schedule actions if there are no items#318Emerson wants to merge 1 commit intohtml-next:mainfrom
Emerson wants to merge 1 commit intohtml-next:mainfrom
Conversation
runspired
approved these changes
May 17, 2021
| run(() => { | ||
| const items = this.get('items'); | ||
| const keyPath = this.get('key'); | ||
| if (!items || items.length === 0) { return; } |
Contributor
There was a problem hiding this comment.
we should also not fire below if index exceeds the bounds of length. Otherwise this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outlined the problem in #317. This is a simple fix that has resolved the issue for me and still passes all tests. Happy to put in a little more work on this, but would need some guidance on where to look 👀.