-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to .NET 6 & Revision 4 #3
base: master
Are you sure you want to change the base?
Conversation
Hi @lillo42, this is excellent! I just ran your code and seeing this test failure:
It looks like your JSON parsing logic is doing some rounding. The
Looking at your code you seem to be calling |
.NET double precision is a bit different than Java/Go I open a ticket on .NET Runtime repo: |
The discrepancy in the test is more severe though, the JSON value |
@boronine I've moved my implementation from Java to Go, and it now seems to be worked; because of that it's necessary to migrate to .NET 6 (latest LTS) because of the |
For what it’s worth, if you require .NET 6, that’ll make the library not usable for me, as I still use it in a “legacy” .NET 4.7.2 project. .NET Standard 2.0 is fine. |
@lillo42 breaking changes are okay because rev3 -> rev4 is arguably a breaking change already. The only issue with the PR is Once I merge the PR I'm going to try to release v2.0.0. |
Migrate to .NET 6; also, I'm following Go approach, so there are some breaking changes.