Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: refactor to AutoRegister facets to schema. #51

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

justlevine
Copy link
Collaborator

What

Refactors the plugin to autoregister facets to the schema. WIP

  • Autogenerate Facet config objects
  • Register where args for each Facet to every RootQueryTo{$PostType}Connection.
  • Register connection edge fields for active facets.
  • Evaluate and integrate Facet pager input and edge field.
  • Autogenerate GraphQL interfaces for individual Facet settings. (Related Map string settings to appropriate types #11 . May be punted to a separate PR/release 🤔)

Why

Closes #31

How

See changelog

Testing Instructions

Additional Info

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine added the safe to test ✔ This PR can be run using repository secrets label Jan 18, 2023
@justlevine justlevine added this to the v0.5.0 milestone Jan 18, 2023
@justlevine justlevine added status: in progress 🚧 Work on this has begun type: feature 🦋 New feature or request labels Jan 18, 2023
@justlevine justlevine force-pushed the feat/autoregister-facets branch from c7c48d7 to a50e047 Compare May 3, 2023 12:46
@justlevine justlevine mentioned this pull request May 3, 2023
5 tasks
justlevine added a commit that referenced this pull request May 3, 2023
@justlevine justlevine force-pushed the feat/autoregister-facets branch from a50e047 to cfe4fc2 Compare May 3, 2023 21:40
@justlevine justlevine mentioned this pull request May 10, 2023
5 tasks
@justlevine justlevine force-pushed the feat/autoregister-facets branch from cfe4fc2 to 215fd10 Compare June 5, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test ✔ This PR can be run using repository secrets status: in progress 🚧 Work on this has begun type: feature 🦋 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autogenerate facets as connection where args
1 participant