Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accuracy parameter to comma function to fix rounding. #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hcraT
Copy link
Contributor

@hcraT hcraT commented Mar 22, 2019

I think that the function comma has been changed and now by default number get rounded to the nearest integer. The pull request adds the parameter to restore the original behavior that was to print one decimal digit.
Without PR:

> byte_format()(1.5 * 1024^3)
[1]  "2 Gb"

with PR

> byte_format()(1.5 * 1024^3)
[1]  "1.5 Gb"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant