Dbp 1037 setup privacyidea monitring #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t handlers for various events
| @@ -63,3 +63,4 @@ | |||
| path: "/tmp/certificate_sync_key_*" | |||
| state: absent | |||
| delegate_to: localhost | |||
| ignore_errors: true | |||
There was a problem hiding this comment.
Is there a reason for ignoring errors here?
| # args: | ||
| # executable: /bin/bash | ||
| # notify: restart uwsgi | ||
|
|
There was a problem hiding this comment.
Is there a reason for commenting this out? There is a when condition in the main.yml so it would only be executed if privacyidea_execute_data_import is true.
| - name: Install prometheus_client in PrivacyIDEA | ||
| ansible.builtin.command: | ||
| cmd: sudo -H /opt/privacyidea/virtualenv/bin/pip install prometheus_client | ||
| become: true |
There was a problem hiding this comment.
May be the ansible pip module could be more elegant here? I think it supports virtualenvs.
|
|
||
| def check_auth(username, password): | ||
| """Check if a username/password combination is valid.""" | ||
| return username == EXPORTER_USERNAME and password == EXPORTER_PASSWORD |
There was a problem hiding this comment.
I think this could potentially be vulnerable for timing attacks.
Maybe we could use a hash and standard method from bcrypt instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on creating a robust monitoring setup for PrivacyIDEA by developing a custom exporter that collects vital statistics from PrivacyIDEA's database and exposes them in a format that Prometheus can scrape.
Custom Exporter Configuration
The custom exporter will follow this chain of communication: