Declare all CLI prog deps with <PROG>_CMD variables #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all literal "git", "wc" and "grep" strings throughout gitstats with corresponding <PROG>_CMD variables. (Also upper-case existing "gnuplot_cmd" variable while at it.) NixOS/nixpkgs[1] generally patch programs at build time to call their CLI deps with absolute paths (meaning: known versions of those deps). This makes packaging across different unix systems much more reliable. This patch makes it easier to do that build time patching :-) [1]: http://nixos.org/nix/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all literal "git", "wc" and "grep" strings throughout gitstats with
corresponding _CMD variables. (Also upper-case existing "gnuplot_cmd"
variable while at it.)
NixOS/nixpkgs1 generally patch programs at build time to call their
CLI deps with absolute paths (meaning: known versions of those deps).
This makes packaging across different unix systems much more reliable.
This patch makes it easier to do that build time patching :-)