Eslint & Prettier setup and some lint error fixes #6717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade eslint to v9 - Upgrade prettier to v3 - Setup config files with latest standards
github-actions
bot
added
dependencies
- Address `no-unused-vars` lint errors
royallsilwallz
force-pushed
the
fix/typescript-vite-issues
branch
from
b8f5f4c to
7b20d10
Compare
royallsilwallz
force-pushed
the
fix/typescript-vite-issues
branch
from
7b20d10 to
442f8f9
Compare
JoltCode
approved these changes
Jan 26, 2025
| noBg?: boolean; | ||
| }, | ||
| ) => { | ||
| const { ...rest } = props; |
There was a problem hiding this comment.
The destructuring should still be here
There was a problem hiding this comment.
whoa! nice catch Joe. I'll update it! 🚀
|
|
@royallsilwallz LGTM! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Describe this PR
Changes
yarn lint --fixno-unused-varseslint errorsTODOS.mdfor tracking remaining tasks