-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Render markdown correctly for short descriptions #6683
base: develop
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Thanks for the PR @asmigarg04 ! While this is a great issue to address, there are a couple of problems with the PR:
One approach could be to add a markdown renderer to the frontend, as you have done in this PR (I will let the devs decide on if that is a good approach for them). Or another would be to run the project description through the markdown renderer on the backend first, before it's passed to the frontend and displayed. Thanks again! Let's hear back from the team to see what they think is best 😄 |
Thanks @spwoodcock for reviewing my PR. Please let me know if in any way I can help to improve and work on this issue further. |
Hi ,@spwoodcock . Can you please let me know if there are any updates regarding this issue? |
Hi @asmigarg04! Sorry it's down to the dev team to consider the correct approach to this and reply (my hunch is this needs to be done on the backend, returning a pre-rendered HTML response from the Markdown) - I'm assuming they might have other urgent priorities to attend to for now 😅 Thanks for the patience 🙏 |
It's alright. Thanks for informing. |
Hi @asmigarg04, thank you for addressing the issue and raising a PR. 🚀 I have reviewed your PR and have the following comments -
Feel free to ask if you have any further queries. 🙏 Also, thank you @spwoodcock for the quick response, review and feedback! ✨ |
What type of PR is this? (check all applicable)
Fixes issue #6674
Describe this PR
This PR addresses a longstanding issue where markdown in the short descriptions of project cards (e.g., URLs) was not rendered correctly. This bug caused markdown syntax (like text) to display as plain text instead of being interpreted as clickable links.
##Changes made
Updated the ProjectCard component to ensure the shortDescription field renders markdown properly.
Integrated a markdown-to-HTML parser (react-markdown) for safe and efficient markdown rendering.